Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support not_equal queries for none and nan #988

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

daniel-sanche
Copy link
Contributor

Building off of #971

allow != for None and Nan comparisons:

  • x.where("field", "!=", None)
  • x.where("field", "!=", float(nan))

Fixes #970

Thanks @mgraczyk!

@daniel-sanche daniel-sanche requested review from a team as code owners December 20, 2024 00:41
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: firestore Issues related to the googleapis/python-firestore API. labels Dec 20, 2024
@daniel-sanche daniel-sanche changed the title Is not null operator feat: support not_equal for none and nan Dec 20, 2024
@daniel-sanche daniel-sanche changed the title feat: support not_equal for none and nan feat: support not_equal queries for none and nan Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement IS_NOT_NULL
3 participants